Re: [PATCH 21/34] arm64: dts: qcom: msm8998: Move PCIe phy and GPIOs to root port node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to move `phy-names` to the root port node, but the property is actually deleted.
--

commit 5db263a0e4f8f01c847c35b40997163432b4247b
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

arm64: dts: qcom: msm8998: Move PCIe phy and GPIOs to root port node

This commit moves the pcie phy reference and the perst gpio property
from the RC controller node to the root port node (pcie@0) for the
msm8998 devicetree. It also renames the perst gpio to reset-gpios
and adds a label to the root port node.

> The PCIe phy reference and the perst GPIO property are per root port
> and belong in the root port node (pcie@0), not in the RC controller
> node. Move phys, phy-names, and perst-gpios from the controller to
> pcie0_port0, adding a label to this node to allow board-level
> overrides, and renaming perst-gpios to reset-gpios to match the
> binding used in the root port context.

[Severity: Medium]
The commit message claims to move phy-names to the root port node, but the
property is actually deleted in the patch. Should the commit message be
updated to reflect this omission?

The omission appears to be structurally correct per the device tree bindings
(Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml), which state
that phy-names is not required in the root port as it only has one phy, but
the commit message contradicts this intentional deletion.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-root_port-v1-0-90a252ddbbfa@oss.qualcomm.com?part=21