Re: [PATCH 22/34] arm64: dts: qcom: qcs404: Move PCIe phy and GPIOs to root port node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message incorrectly claims that `phy-names` is moved to the root port node, but it is actually dropped.
--

commit 43e475189be13ef7a3db0e296715dd66a66766c9
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

arm64: dts: qcom: qcs404: Move PCIe phy and GPIOs to root port node

This commit moves the PCIe phy reference and perst GPIO property from the
RC controller node to the root port node, renaming the GPIO to reset-gpios.
It adds a label to the root port node to allow board-level overrides.

> Move phys and phy-names from the controller to pcie0_port0,
> adding a label to this node to allow board-level overrides.

[Severity: Medium]
The commit message states that phy-names is moved to pcie0_port0, but
looking at the diff, it appears to be removed entirely rather than moved.
Is this omission intentional since the driver might look up the PHY without
a connection ID, and could the commit message be updated to reflect that it
is dropped?

> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -1517,16 +1517,15 @@ pcie: pcie@10000000 {
[ ... ]
> -			phys = <&pcie_phy>;
> -			phy-names = "pciephy";
> -
>  			status = "disabled";
>  
> -			pcie@0 {
> +			pcie0_port0: pcie@0 {
>  				device_type = "pci";
>  				reg = <0x0 0x0 0x0 0x0 0x0>;
>  				bus-range = <0x01 0xff>;
>  
> +				phys = <&pcie_phy>;
> +

[Severity: Medium]
As noted above, we add phys here in pcie0_port0 but omit phy-names which
was present in the parent node. Does this child node also need the phy-names
property to match the commit message, or is dropping it the intended behavior?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-root_port-v1-0-90a252ddbbfa@oss.qualcomm.com?part=22