Re: [PATCH 34/34] arm64: dts: qcom: sm8550: Move PCIe phy and GPIOs to root port node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately claims that `phy-names` is moved to the root port node and that `pcie1_port0` is a newly added label.
--

commit 5a165f26f5136ff46d1b26908e6f480f88cfa37b
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

arm64: dts: qcom: sm8550: Move PCIe phy and GPIOs to root port node

This commit updates the sm8550 devicetrees to move the PCIe PHY references
and the PERST/WAKE GPIO properties from the root complex controller nodes
down to the respective root port nodes. It also renames perst-gpios to
reset-gpios to match the root port binding context. These changes enable
board-level overrides for port-specific configurations.

> Move phys and phy-names from the controller to
> the existing pcieport0 and newly labeled pcie1_port0, allowing
> board-level overrides.

[Severity: Medium]
Is this description accurate? Looking at the baseline code in sm8550.dtsi,
the pcie1_port0 label already exists and doesn't appear to be newly added
by this commit.

> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 0e701e709235c..9bbc31346f900 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -2397,9 +2397,6 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>  
>  			power-domains = <&gcc PCIE_0_GDSC>;
>  
> -			phys = <&pcie0_phy>;
> -			phy-names = "pciephy";
> -
>  			operating-points-v2 = <&pcie0_opp_table>;
>  
>  			status = "disabled";
> @@ -2461,6 +2458,8 @@ pcie0_port0: pcie@0 {
>  				reg = <0x0 0x0 0x0 0x0 0x0>;
>  				bus-range = <0x01 0xff>;
>  
> +				phys = <&pcie0_phy>;
> +
>  				#address-cells = <3>;
>  				#size-cells = <2>;
>  				ranges;

[Severity: Medium]
The commit message states that phy-names is being moved to the root port
node, but it looks like it was dropped from the controller and not
re-added here alongside phys. Was phy-names intentionally removed instead
of being moved?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-root_port-v1-0-90a252ddbbfa@oss.qualcomm.com?part=34